DG1924: Param changes in task vertex for add tags propagation to increase observability. #3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijeet-atlan
force-pushed
the
taskdg1924
branch
from
fecf0df to
6ec86ed
Compare
jnkrmg
requested changes
Dec 11, 2024
common/src/main/java/org/apache/atlas/repository/Constants.java
Outdated
Show resolved
Hide resolved
...itory/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java
Outdated
Show resolved
Hide resolved
...itory/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/MeaningsTask.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/MeaningsTask.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/tasks/AtlasTaskService.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java
Outdated
Show resolved
Hide resolved
This commit streamlines the handling of asset propagation counts across task-related classes by removing outdated configurations and simplifications in the code: - **Constants.java**: Removed the 'MODIFICATION_TASK_ASSET_COUNT_TO_PROPAGATE_PROPERTY_KEY', eliminating the configuration property for asset count thresholds. - **AtlasTask.java**: Deleted the 'incrementAssetCountPropagated' method to reduce manual asset count manipulations. - **ClassificationTask.java & MeaningsTask.java**: Removed methods setting asset counts to propagate, simplifying task executions. - **AtlasTaskService.java**: Updated task initialization to set asset counts to zero, aligning with the new simplified approach. - **TaskRegistry.java**: Removed an unnecessary sleep operation from the task update process.
jnkrmg
requested changes
Dec 11, 2024
...itory/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/MeaningsTask.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java
Outdated
Show resolved
Hide resolved
jnkrmg
requested changes
Dec 11, 2024
jnkrmg
approved these changes
Dec 11, 2024
hr2904
reviewed
Dec 11, 2024
common/src/main/java/org/apache/atlas/repository/Constants.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Show resolved
Hide resolved
...itory/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
assetsCountToPropagateandassetsCountPropagatedinitialised with0in the task vertex when a task is created.assetsCountToPropagatewith the value of propagation once impacted vertices calculation is finished.assetsCountPropagatedin chunks of 100 as the task progresses (in case of tasks less than 100 its updated in one go.)Type of change
Code review