Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG-1996 : RepairHasLineage API logic fix #4042

Merged
merged 1 commit into from
Jan 29, 2025
Merged

DG-1996 : RepairHasLineage API logic fix #4042

merged 1 commit into from
Jan 29, 2025

Conversation

hr2904
Copy link
Collaborator

@hr2904 hr2904 commented Jan 28, 2025

Change description

When fixing hasLineage for an asset, only edge status is being checked but not process status, which is often deleted in current ongoing customer ticket. This commit fixes that by adding that check.
Scenario is ColumnA [Active] -> Process_input edge [Active] -> DbtColumnProcess[Deleted], due to which this api is not fixing those assets.

Type of change

  • Bug fix (fixes an issue)

Related issues

Fix #1
Testcase

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

…d but not process status, which is often deleted in current ongoing ticket.

This commit fixes that by adding that check
@hr2904 hr2904 merged commit 78273e5 into master Jan 29, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants