Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLH-80 : (feat) Add flag to disable edge restoration during entity restoration #4051

Merged
merged 6 commits into from
Jan 30, 2025

Conversation

sumandas0
Copy link

@sumandas0 sumandas0 commented Jan 29, 2025

Change description

Adding a flag in the API entity/bulk which will skip the restoration of edges; this will improve performance by ignoring unwanted restorations.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Sorry, something went wrong.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumandas0 , this is a big diff! is this intended ?

AtlasVertex inVertex = edge.getInVertex();
AtlasStructType.AtlasAttribute attribute = getAttributeForEdge(edge);
// Restore external references to this vertex - incoming edges from lineage or glossary term edges
if (RequestContext.get().isSkipProcessEdgeRestoration())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: uses braces and prevent from accidental wrong indentation!

Copy link

@sriram-atlan sriram-atlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except a nit comment. formatting rules or spotless needs to be applied so reviewer's job becomes simpler @sumandas0

@sriram-atlan
Copy link

a check is failing in the pipeline too @sumandas0

@sumandas0 sumandas0 merged commit fb64dd1 into master Jan 30, 2025
6 of 7 checks passed
@sumandas0 sumandas0 deleted the mlh-80-flag-skip-retoration branch January 30, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants