-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLH-80 : (feat) Add flag to disable edge restoration during entity restoration #4051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumandas0 , this is a big diff! is this intended ?
AtlasVertex inVertex = edge.getInVertex(); | ||
AtlasStructType.AtlasAttribute attribute = getAttributeForEdge(edge); | ||
// Restore external references to this vertex - incoming edges from lineage or glossary term edges | ||
if (RequestContext.get().isSkipProcessEdgeRestoration()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: uses braces and prevent from accidental wrong indentation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except a nit comment. formatting rules or spotless needs to be applied so reviewer's job becomes simpler @sumandas0
a check is failing in the pipeline too @sumandas0 |
Change description
Type of change