Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLTS-51 | Add full log in body attr and fix resource attr in auth audit #4074

Merged
merged 4 commits into from
Feb 10, 2025
Merged

PLTS-51 | Add full log in body attr and fix resource attr in auth audit #4074

merged 4 commits into from
Feb 10, 2025

Conversation

krsoninikhil
Copy link

@krsoninikhil krsoninikhil commented Feb 3, 2025 •
edited
Loading

Change description

  • This changes body of atlas audit log to be more useful which is helpful exploring logs.
Change Earlier Now
Atlas Audit log message Screenshot 2025-02-05 at 5 02 10 PM Screenshot 2025-02-05 at 5 02 44 PM
Auth Audit Resource Attribute image image

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@krsoninikhil krsoninikhil force-pushed the ns/fix/log-attr branch 2 times, most recently from 5e3817c to a598b40 Compare February 7, 2025 14:54
hr2904
hr2904 approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@hr2904 hr2904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@krsoninikhil krsoninikhil merged commit 72e6e57 into master Feb 10, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hr2904 hr2904 hr2904 approved these changes

@sumandas0 sumandas0 Awaiting requested review from sumandas0

@nikhilbonte21 nikhilbonte21 Awaiting requested review from nikhilbonte21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krsoninikhil @hr2904