Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fullscreen and maximized window logic. #3435

Closed
wants to merge 2 commits into from
Closed

Refactor fullscreen and maximized window logic. #3435

wants to merge 2 commits into from

Commits on Jul 26, 2024

  1. Refactor fullscreen and maximized window logic. 

    The new foreign interface architecture handles the state of the relevant window
slots (such as fullscreen-p) instead of doing that on the renderer packages.
This replaces the need for the :skip-renderer-resize keyword.

Fixed bug in toggle-message-buffer, where the height of the buffer was being
probed incorrectly.

Refactor how the window-state-event in handled in GTK.

Simplify implementation of toggle-fullscreen, toggle-maximize,
toggle-status-buffer and toggle-message-buffer.

In terms of the UI:

- a fullscreen invoked by the user or by the window manager expands the UI
fully (keeping the status and message buffers);

- a fullscreen requested by the renderer (e.g. fullscreen video stream) hide the
status and message buffers.
    @aadcg
    aadcg committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    7017cdb View commit details
    Browse the repository at this point in the history

  2. changelog: Mention fullscreen logic fix.

    @aadcg
    aadcg committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    de9cb2c View commit details
    Browse the repository at this point in the history