Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer.lisp: Fix rendering of buffer menu on long pages. #3443

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

jmercouris
Copy link
Member

@jmercouris jmercouris commented Aug 1, 2024

Additionally, change the width of the menu to be the same as the content, make it a clearer visual indicator that it operates on the content.

Fixes #3416.

@jmercouris jmercouris requested a review from aadcg August 1, 2024 04:21
@jmercouris jmercouris mentioned this pull request Aug 1, 2024
jmercouris and others added 2 commits August 1, 2024 11:52
Additionally, change the width of the menu to be the same as the content, make
it a clearer visual indicator that it operates *on* the content.
@aadcg
Copy link
Member

aadcg commented Aug 1, 2024

Thanks for the fix!

A couple of notes for the future:

  • Don't forget the changelog entry;
  • Always add the issue the PR fixes so that it is automatically closed on PR merge;
  • Note that you're using tabs instead of spaces (therefore the additions weren't properly indented);
  • Always rebase on top of master.

Fixed all of these and merged.

@aadcg aadcg merged commit 14a3dcc into master Aug 1, 2024
0 of 3 checks passed
@aadcg aadcg deleted the bugfix/buffer-menu branch August 1, 2024 08:58
@jmercouris
Copy link
Member Author

Yes, sorry about that. It has been a while since I've made a proper PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

render-menu UI bug
2 participants