ARC-2290 new jira client part two #2466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reated helper file aswell which needs coverage
joshkay10
changed the base branch from
main
to
ARC-2290-new-jira-client-part-one
joshkay10
changed the base branch from
ARC-2290-new-jira-client-part-one
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Hurray, this is the new JiraClient class, takes the two existing ones and munges them together in a semi elegant way.....
This is not its final form, i expect some abstraction moving forward but this does collect everything together
Why
We have wanted to for sometime, two seperate jiraClients it diffrent directories ones a class ones not, just was getting messy, plus i want to add the TCS(tenantContextService) sidecar so i can run a axios interceptor on Jira calls so we dont call dead Jiras and now was a good time to make this change :excite:
Added feature flags
Not yet, next steps will need a bunch
Whats Next?
Start peeling off usage of old jiraclients and feature flagging them to this client..... gunna be quite a few so will just chip away