Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/update dependecy cqrs&buckets #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feat/update dependecy cqrs&buckets #23

wants to merge 4 commits into from

Conversation

shifuwww
Copy link

No description provided.

@shifuwww shifuwww self-assigned this Sep 30, 2023
SlumberyDude
SlumberyDude suggested changes Oct 2, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@SlumberyDude
Copy link

@TorinAsakura Привет, тут превью чек не проходит, падает на шаге Login to Google Container Registry

Run echo -e $GCR_KEYFILE | docker login -u _json_key --password-stdin https://eu.gcr.io/
Error: Cannot perform an interactive login from a non TTY device
Error: Process completed with exit code 1.

Такое ощущение, что $GCR_KEYFILE невалиден

@TorinAsakura
Copy link
Member

@TorinAsakura Привет, тут превью чек не проходит, падает на шаге Login to Google Container Registry

Run echo -e $GCR_KEYFILE | docker login -u _json_key --password-stdin https://eu.gcr.io/
Error: Cannot perform an interactive login from a non TTY device
Error: Process completed with exit code 1.

Такое ощущение, что $GCR_KEYFILE невалиден

агаг, если быть точным - его просто нет, оставьте этот ПР пока да на меня перевесьте

@shifuwww shifuwww requested review from SlumberyDude and TorinAsakura and removed request for SlumberyDude October 2, 2023 20:08
@TorinAsakura
Copy link
Member

@shifuwww почему у ПРа нет задачи?

@shifuwww shifuwww linked an issue Oct 2, 2023 that may be closed by this pull request
Обновление зависимостей cqrs-adapter и buckets-config-adapter #22
Open
@shifuwww
Copy link
Author

shifuwww commented Oct 2, 2023

@shifuwww почему у ПРа нет задачи?

@TorinAsakura Добавил

@TorinAsakura TorinAsakura requested review from Nelfimov and removed request for TorinAsakura January 8, 2024 23:22
@Nelfimov Nelfimov assigned Nelfimov and unassigned TorinAsakura and shifuwww Jan 10, 2024
Nelfimov
Nelfimov requested changes Jan 10, 2024
View reviewed changes
Copy link
Member

@Nelfimov Nelfimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

доработать

@TorinAsakura
Copy link
Member

доработать

ты это кому?

@Nelfimov
Copy link
Member

Себе конечно. Иначе висит в списке на ревью

Nelfimov
Nelfimov requested changes Apr 8, 2024
View reviewed changes
Copy link
Member

@Nelfimov Nelfimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

на доработку

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SlumberyDude SlumberyDude SlumberyDude requested changes

@Nelfimov Nelfimov Nelfimov requested changes

Assignees

@Nelfimov Nelfimov

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Обновление зависимостей cqrs-adapter и buckets-config-adapter
5 participants
@shifuwww @SlumberyDude @TorinAsakura @Nelfimov @shifuww