This repository was archived by the owner on Nov 10, 2017. It is now read-only.
Support for new deployment options #116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atmos bumppppp. Any thought about getting this in? |
atmos
suggested changes
Oct 6, 2016
| @autoMerge = true | ||
| @transientEnvironment = undefined | ||
| @productionEnvironment = undefined | ||
| @environments = { "production" : {}} |
There was a problem hiding this comment.
The change on the environment class from an array to an object seems fishy
|
Can you merge my env_type branch into yours? |
BC break should be avoided IMO, so both syntaxes should be supported. |
|
any update on this ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per GitHub's blog and documentation, there are now new options for deployments (transient, production, auto_inactive). This PR implements support for those options.
Note that although the samples in
config_file.mddon't show entries such asheroku_test_name, those are still carried over in the payload. They would now better fit in theprovider_env_nameentry.