Neo Trinkey

[Gisleburt]

Something a bit more my complexity level, with a whopping 3 pins. 😅

Neo Trinkey is an ATSAMD21E based board with 4 Neo Pixels (aka WS2812) controlled by one pin, and two capacative touch pads.

ToDo:

• Get NeoPixels to light up
• Receive input from capacative pads
• Set up USB device

[Gisleburt]

I've run into some problems with the capacitive touch buttons. I'm not sure if I should wait on #420 or whether I should attempt to add a touch sensor following this (simpler looking) guide: http://ww1.microchip.com/downloads/en/AppNotes/01298A.pdf

[Gisleburt]

Sans the touch interface this is done. I'm happy to come back and do the touch interface later if everyone else is ok with that too.

[TDHolmes]

• Can you make an initial CHANGELOG.md?

[Gisleburt]

@TDHolmes added a change log, lmk what you think

[TDHolmes]

I’m down to remove either. Removing echo is fine with me

…

On Thu, Oct 7, 2021 at 7:18 AM Daniel Mason ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In boards/neo_trinkey/examples/usb_ack.rs <#471 (comment)>: > + break; + } + serial.write("Received: ".as_bytes()).ok(); + serial.write(&[c.clone()]).ok(); + serial.write("\r\n".as_bytes()).ok(); + } + }; + }); + }); + }; +} + +#[interrupt] +fn USB() { + poll_usb(); +} From a usability point of view, I had difficulty understanding that what I was typing was just being sent back to me. Adding extra info to the returned data helped me know the program was working as expected. If we were to get rid of one I'd suggest getting rid of echo, however as other bsps already use echo, I kept it for convention. What are your thoughts? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#471 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC5YNWU3JAE2OTCVKCBOIZ3UFWT4FANCNFSM5AQ7JLEQ> .

[TDHolmes]

I’m fine either way you go on the USB examples

[TDHolmes]

LGTM, @jbeaurivage can you take a look, approve running of the CI, and merge if it looks good to you too? I don't have the ability

[bradleyharden]

I'll merge when this goes green.

[TDHolmes]

#505 is needed to fix CI in general. Want to merge that @bradleyharden ? 😊

[TDHolmes]

@Gisleburt this code also needs to go through rustfmt. remove --check from rustfmt.sh and run it

[Gisleburt]

@TDHolmes done, it was the comments which rustfmt only handles on nightly which I wasn't using