Add board support for Arduino MKR WiFi 1010.#606
Add board support for Arduino MKR WiFi 1010.#606Foosvald wants to merge 3 commits intoatsamd-rs:masterfrom
Conversation
|
Hi! Thanks for the PR. I would suggest porting this to |
Absolutely, good idea! I'll do it and push an update :) |
| panic-halt = "0.2" | ||
| panic-semihosting = "0.5" | ||
| usbd-serial = "0.1" | ||
| wifi-nina = { git = "https://github.com/Foosvald/wifi-nina", branch = "invert-reset-logic-with-feature", features = ["reset-high"] } |
There was a problem hiding this comment.
Have you managed to get your changes upstreamed? I don't really like depending on someone's personal branch. That feels very hacky. Plus, I don't think you can even publish to crates.io if you have a Git dependency.
There was a problem hiding this comment.
As of today, the PR is still open and the wifi-nina crate wasn't updated for five years.
There was a problem hiding this comment.
Sir, the contributors who created the PR have been unresponsive. Don't take it out on us.
There was a problem hiding this comment.
Have you managed to get your changes upstreamed? I don't really like depending on someone's personal branch. That feels very hacky. Plus, I don't think you can even publish to crates.io if you have a Git dependency.
I haven't managed to get my changes upstreamed and don't really know how to proceed with this. So I would be fine with closing this MR or letting someone else take over it if there is still interest in supporting this board...
There was a problem hiding this comment.
@sajattack I don't, I simply wanted to ping the thread with a status update. :)
There was a problem hiding this comment.
@Foosvald Would it make sense for you to release a forked version under a different name? I noticed there are two other forks in the network that might be worth looking at as well and according to the Cargo.toml it's MIT or Apache-2.0 licensed, so it should be fine.
There was a problem hiding this comment.
Another, easier way to get this unblocked is to release the BSP without wifi examples, and leave wifi as an exercise to the user.
|
@Foosvald, I think this looks good. The Git dependency is the only show stopper. Have you tested all your examples? |
This is essentially just copying the example code from @Foosvald's PR atsamd-rs/atsamd#606
5 participants
Summary
This adds initial board support for the Arduino MKR WiFi 1010 board.
(This is my first PR here and I'm also pretty new to both embedded and Rust, so I hope I've done everything correctly. And I would be happy to fix anything according to your feedback!)
The wifi_nina library hasn't been updated in a while so I currently use my fork of it until (or if) dflemstr/wifi-nina#6 is merged upstream.
.
Checklist
CHANGELOG.mdfor the BSP or HAL updatedIf Adding a new Board
crates.json