DRAFT - Rewrite of ADC code#811
Closed
rnd-ash wants to merge 14 commits intoatsamd-rs:feat/adc-v2from
Closed
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…al (atsamd-rs#804) Implement `rtic_time::Monotonic` (RTIC v2.0) trait for RTC peripheral on all platforms --------- Co-authored-by: Dan Whitman <daniel.whitman.2@us.af.mil> Co-authored-by: Dan Whitman <dwhitman44@mgail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR - Don't merge
As mentioned in #796 , the ADC code requires a re-write in order to make it compatible with Clock V2 API, and to give it an async API.
This Draft PR will track progress I'm making towards this goal.
I've so far created a settings builder type that should be compatible with both 21 and 51 series chips, it allows the user to configure more parameters on how the ADC will sample its data (Along with some good defaults). This is required since due to Clock V2, the ADC clock might not be running at 48Mhz, meaning there is no way to assume the actual sample rate of the ADC at the HAL level, therefore this settings builder also has a
calculate_spsmethod so that the user can get an estimated sample rate of the ADC with their desired settings.