-
Notifications
You must be signed in to change notification settings - Fork 219
Add support for PIC32CX SG series #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rnd-ash
wants to merge
15
commits into
atsamd-rs:master
Choose a base branch
from
rnd-ash:feat/pic32cxsg
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4f92578
Add note about using the crate in its existing form with PIC32CXSG (#…
rnd-ash a68f040
Merge branch 'master' into feat/pic32cxsg
rnd-ash e9b5054
Add RAM size to description of PIC32s
rnd-ash adfcebf
Add pic32cxsg configurations to devices.yaml
rnd-ash cd0849c
Update crates to include pic32cxsg line
rnd-ash 205ab5a
Add to define_pac macro
rnd-ash 4b6be20
Move pic32cxsg series to existing d5x devices section
rnd-ash f708abb
Differentiate between 4x and 6x PIC32CXSGs, and add HSM flag
rnd-ash b7f3954
Update README and crates.json
rnd-ash 0e19661
Remove PIC32CX flashing section
rnd-ash b5b3389
Fix devices.yml
rnd-ash 50a5ea2
Feature gate some peripherals for SG60/61 (To disable pins used for H…
rnd-ash 234e15c
Remove 1025 from the PIC names (Flash size)
rnd-ash 8cf0b7e
Fix define_pac macro
rnd-ash ed0947b
Revert Cargo.toml auto-format
rnd-ash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This language makes the PIC32CX SG feel really "bolted on", maybe something like "working with Microchip SAMD family of devices including SAMD11, SAMD21...PIC32CX SG."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would
"This repository holds various crates that support/enable working with Atmel (Now Microchip) devices (
samd11,samd21,samd51andsame5x), as well as Microchip's ownPIC32CX SGseries using Rust "sound better then?
(We could change this into a list, to better future proof this if we eventually get around to 1 day adding the next generation PIC32C series of ICs)