Extend ATL-128 to the enabledMcpjsonServers allowlist vector#103
Merged
Conversation
A committed allowlist pre-enables the named project servers for anyone who clones, and pins names rather than launch targets, so a poisoned .mcp.json can swap the target behind an allowlisted name (Check Point, CVE-2026-21852 advisory). Fail-closed on every non-list-of-strings shape. Closes #99. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
zeyadalsakhii
force-pushed
the
fix/atl-128-allowlist
branch
from
July 24, 2026 23:10
4adc397 to
aa6a177
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #99.
Check Point's Feb 2026 advisory (the CVE-2026-21852 write-up ATL-128 already cites) showed committed settings pre-enabling project MCP servers through the enabledMcpjsonServers allowlist, not only the enable-all boolean. The allowlist pins server NAMES, not launch targets, so a poisoned .mcp.json swaps the target behind an allowlisted name.
_auto_enable_project_mcpnow also trips on a non-empty list-of-strings allowlist; every other shape (dict, empty list, non-list, mixed types) fails closed, each shape tested.Merge note: merge #102 first - both PRs regenerate website/docs.html, so this one will need a trivial rebase + re-render after #102 lands (say the word and it is one command).
Generated with Claude Code.