Skip to content

Fix zsh_histdb import issue#2350

Open
tru2dagame wants to merge 1 commit intoatuinsh:mainfrom
tru2dagame:patch-1
Open

Fix zsh_histdb import issue#2350
tru2dagame wants to merge 1 commit intoatuinsh:mainfrom
tru2dagame:patch-1

Conversation

@tru2dagame
Copy link
Copy Markdown

Fix Import Error by Modifying Order Clause

This PR addresses an import zsh-hist-db error by changing the order clause in the query.
The current implementation uses ORDER BY history.start_time, which is causing issues. The fix involves using ORDER BY history.id instead. The order by id and start_time produces the same sequence, and since id is the primary key, this change may improve the query performance.

Screenshots

Error Screenshot:
image
Histdb Query Testing:
image image

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant