SDF: Expose optional setvar_vaddr for map and page_size for memory region.#19
SDF: Expose optional setvar_vaddr for map and page_size for memory region.#19
Conversation
Kswin01
force-pushed
the
mr_map_options
branch
2 times, most recently
from
339d7d4 to
56820f6
Compare
|
I think a better approach would be to have a |
|
|
||
| var options: Mr.Options = .{}; | ||
| if (page_size != null) { | ||
| const page_size_enum: Mr.PageSize = switch (page_size.*) { |
There was a problem hiding this comment.
I remember having .fromInt in sdf.zig for this case.
There was a problem hiding this comment.
Yep missed that, I can switch to using that now. fromInt requires an architecture to be passed, should we change the API for mr_create so that a user can pass in the arch?
Switched to this implementation |
Kswin01
force-pushed
the
mr_map_options
branch
from
2b18633 to
2909db6
Compare
Signed-off-by: Krishnan Winter <krishnanwinter1@gmail.com>
Signed-off-by: Krishnan Winter <krishnanwinter1@gmail.com>
Kswin01
force-pushed
the
mr_map_options
branch
from
2909db6 to
952f17b
Compare
2 participants
Expose optional setvar_vaddr and page_size setting to the python interface.