ci/nix: downgrade python to 3.9, enforce in scripts#639
Open
JDuchniewicz wants to merge 1 commit intomainfrom
Open
ci/nix: downgrade python to 3.9, enforce in scripts#639JDuchniewicz wants to merge 1 commit intomainfrom
JDuchniewicz wants to merge 1 commit intomainfrom
Conversation
JDuchniewicz
force-pushed
the
jakub/python_version_check
branch
from
d7ac865 to
3202947
Compare
| inputs = { | ||
| nixpkgs.url = "github:NixOS/nixpkgs/nixos-25.05"; | ||
| # Python 3.9 is not in the official repo anymore | ||
| python39.url = "github:NixOS/nixpkgs/c5dd43934613ae0f8ff37c59f61c507c2e8f980d"; |
Contributor
There was a problem hiding this comment.
this is going to download duplicates of everything including entire libc and everything, which is a lot of extra things to download
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
Collaborator
|
Hmm not sure about this. If it's not in Nix packages I'm not sure it's worth it. |
Collaborator
|
The Mac Mini self-hosted runner has Python 3.9 so the only other thing I was thinking is to manually run Not the best solution but would have caught some of the errors that we've been running into. |
Contributor
Author
|
I am in general against bounding dependencies from above. However, other than forcing users to manually verify with python3.9 or dropping support for older python versions, I don't see a better solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents issues with too new Python version features, like #629
If anyone has a better way of preventing that, I'm willing to change it.