feat: added NuGet and npm packages licenses checks on PR build validation #172347 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackpercy-acl
requested changes
Dec 13, 2024
There was a problem hiding this comment.
Not sure if these 3 files should be in the build folder? Maybe like the dependency check steps they could live in /src/security/license-checks/?
Not sure they are strictly security though 😆 happy to see what anyone else thinks.
| inputs: | ||
| scriptType: inlineScript | ||
| inlineScript: | | ||
| $licenses = @("MIT","Apache-2.0","BSD-3-Clause","Apache-2.0 OR MPL-2.0","MS-EULA","X11","Unlicense","0BSD","BSD-2-Clause") |
There was a problem hiding this comment.
There definitely doesn't need to be any project specific overrides of any of these configs? Or at least not in v1?
| @@ -69,6 +69,10 @@ jobs: | |||
| --configuration Release | |||
| --no-restore | |||
|
|
|||
| - template: /src/build/common/steps/license-checks.steps.yaml | |||
There was a problem hiding this comment.
Does this need to happen after the build? It can't go up at the top with the dependency check? Feels a bit random here between Build and Test
| steps: | ||
| - script: | | ||
| dotnet new tool-manifest | ||
| dotnet tool install dotnet-project-licenses |
There was a problem hiding this comment.
Is this the one being installed? It says it is abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code ready for review
YAML pipeline syntax validated
README or other documentation updated
Added/updated logging
Pipeline triggers verified
Secrets and variables managed
Dependency licenses
Pipeline steps documented
Security vulnerabilities checked