fix(composition): use transient lifetime for composed view-models.

Closes #22
aurelia-contrib · Dec 17, 2017 · 93a2892 · 93a2892
1 parent c04ff7a
commit 93a2892
Show file tree

Hide file tree

Showing 22 changed files with 84 additions and 70 deletions.
diff --git a/dist/amd/knockout-bindable.js b/dist/amd/knockout-bindable.js
@@ -7,7 +7,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
 define(["require", "exports", "aurelia-binding", "aurelia-templating", "aurelia-dependency-injection", "knockout"], function (require, exports, aurelia_binding_1, aurelia_templating_1, aurelia_dependency_injection_1, ko) {
     "use strict";
     Object.defineProperty(exports, "__esModule", { value: true });
-    var KnockoutBindable = (function () {
+    var KnockoutBindable = /** @class */ (function () {
         function KnockoutBindable(observerLocator) {
             this.subscriptions = [];
             this.observerLocator = observerLocator;
@@ -58,10 +58,10 @@ define(["require", "exports", "aurelia-binding", "aurelia-templating", "aurelia-
         KnockoutBindable.prototype.getObserver = function (target, key) {
             return this.observerLocator.getObserver(target, key);
         };
+        KnockoutBindable = __decorate([
+            aurelia_dependency_injection_1.inject(aurelia_binding_1.ObserverLocator)
+        ], KnockoutBindable);
         return KnockoutBindable;
     }());
-    KnockoutBindable = __decorate([
-        aurelia_dependency_injection_1.inject(aurelia_binding_1.ObserverLocator)
-    ], KnockoutBindable);
     exports.KnockoutBindable = KnockoutBindable;
 });
diff --git a/dist/amd/knockout-composition.js b/dist/amd/knockout-composition.js
@@ -54,7 +54,7 @@ define(["require", "exports", "knockout", "aurelia-dependency-injection", "aurel
     function loadModule(moduleId, loader) {
         return loader.loadModule(moduleId);
     }
-    var KnockoutComposition = (function () {
+    var KnockoutComposition = /** @class */ (function () {
         function KnockoutComposition(compositionEngine, container, loader) {
             this.compositionEngine = compositionEngine;
             this.container = container;
@@ -162,13 +162,14 @@ define(["require", "exports", "knockout", "aurelia-dependency-injection", "aurel
                         return result;
                     }
                 }
+                _this.container.registerTransient(result);
                 return _this.container.get(result);
             });
         };
+        KnockoutComposition = __decorate([
+            aurelia_dependency_injection_1.inject(aurelia_templating_1.CompositionEngine, aurelia_dependency_injection_1.Container, aurelia_loader_1.Loader)
+        ], KnockoutComposition);
         return KnockoutComposition;
     }());
-    KnockoutComposition = __decorate([
-        aurelia_dependency_injection_1.inject(aurelia_templating_1.CompositionEngine, aurelia_dependency_injection_1.Container, aurelia_loader_1.Loader)
-    ], KnockoutComposition);
     exports.KnockoutComposition = KnockoutComposition;
 });
diff --git a/dist/amd/knockout-custom-attribute.js b/dist/amd/knockout-custom-attribute.js
@@ -21,7 +21,7 @@ define(["require", "exports", "aurelia-dependency-injection", "aurelia-templatin
         }
         return null;
     }
-    var KnockoutCustomAttribute = (function () {
+    var KnockoutCustomAttribute = /** @class */ (function () {
         function KnockoutCustomAttribute(element) {
             this.element = element;
         }
@@ -51,11 +51,11 @@ define(["require", "exports", "aurelia-dependency-injection", "aurelia-templatin
         KnockoutCustomAttribute.prototype.unbind = function () {
             ko.cleanNode(this.element);
         };
+        KnockoutCustomAttribute = __decorate([
+            aurelia_templating_1.customAttribute('knockout'),
+            aurelia_dependency_injection_1.inject(Element)
+        ], KnockoutCustomAttribute);
         return KnockoutCustomAttribute;
     }());
-    KnockoutCustomAttribute = __decorate([
-        aurelia_templating_1.customAttribute('knockout'),
-        aurelia_dependency_injection_1.inject(Element)
-    ], KnockoutCustomAttribute);
     exports.KnockoutCustomAttribute = KnockoutCustomAttribute;
 });
diff --git a/dist/amd/require-polyfill.js b/dist/amd/require-polyfill.js
@@ -7,7 +7,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
 define(["require", "exports", "aurelia-loader", "aurelia-dependency-injection"], function (require, exports, aurelia_loader_1, aurelia_dependency_injection_1) {
     "use strict";
     Object.defineProperty(exports, "__esModule", { value: true });
-    var RequirePolyfill = (function () {
+    var RequirePolyfill = /** @class */ (function () {
         function RequirePolyfill(loader) {
             this.loader = loader;
         }
@@ -44,10 +44,10 @@ define(["require", "exports", "aurelia-loader", "aurelia-dependency-injection"],
                 };
             }
         };
+        RequirePolyfill = __decorate([
+            aurelia_dependency_injection_1.inject(aurelia_loader_1.Loader)
+        ], RequirePolyfill);
         return RequirePolyfill;
     }());
-    RequirePolyfill = __decorate([
-        aurelia_dependency_injection_1.inject(aurelia_loader_1.Loader)
-    ], RequirePolyfill);
     exports.RequirePolyfill = RequirePolyfill;
 });
diff --git a/dist/commonjs/knockout-bindable.js b/dist/commonjs/knockout-bindable.js
@@ -10,7 +10,7 @@ var aurelia_binding_1 = require("aurelia-binding");
 var aurelia_templating_1 = require("aurelia-templating");
 var aurelia_dependency_injection_1 = require("aurelia-dependency-injection");
 var ko = require("knockout");
-var KnockoutBindable = (function () {
+var KnockoutBindable = /** @class */ (function () {
     function KnockoutBindable(observerLocator) {
         this.subscriptions = [];
         this.observerLocator = observerLocator;
@@ -61,9 +61,9 @@ var KnockoutBindable = (function () {
     KnockoutBindable.prototype.getObserver = function (target, key) {
         return this.observerLocator.getObserver(target, key);
     };
+    KnockoutBindable = __decorate([
+        aurelia_dependency_injection_1.inject(aurelia_binding_1.ObserverLocator)
+    ], KnockoutBindable);
     return KnockoutBindable;
 }());
-KnockoutBindable = __decorate([
-    aurelia_dependency_injection_1.inject(aurelia_binding_1.ObserverLocator)
-], KnockoutBindable);
 exports.KnockoutBindable = KnockoutBindable;
diff --git a/dist/commonjs/knockout-composition.js b/dist/commonjs/knockout-composition.js
@@ -57,7 +57,7 @@ function processInstruction(instruction) {
 function loadModule(moduleId, loader) {
     return loader.loadModule(moduleId);
 }
-var KnockoutComposition = (function () {
+var KnockoutComposition = /** @class */ (function () {
     function KnockoutComposition(compositionEngine, container, loader) {
         this.compositionEngine = compositionEngine;
         this.container = container;
@@ -165,12 +165,13 @@ var KnockoutComposition = (function () {
                     return result;
                 }
             }
+            _this.container.registerTransient(result);
             return _this.container.get(result);
         });
     };
+    KnockoutComposition = __decorate([
+        aurelia_dependency_injection_1.inject(aurelia_templating_1.CompositionEngine, aurelia_dependency_injection_1.Container, aurelia_loader_1.Loader)
+    ], KnockoutComposition);
     return KnockoutComposition;
 }());
-KnockoutComposition = __decorate([
-    aurelia_dependency_injection_1.inject(aurelia_templating_1.CompositionEngine, aurelia_dependency_injection_1.Container, aurelia_loader_1.Loader)
-], KnockoutComposition);
 exports.KnockoutComposition = KnockoutComposition;
diff --git a/dist/commonjs/knockout-custom-attribute.js b/dist/commonjs/knockout-custom-attribute.js
@@ -23,7 +23,7 @@ function getFirstBoundChild(rootNode) {
     }
     return null;
 }
-var KnockoutCustomAttribute = (function () {
+var KnockoutCustomAttribute = /** @class */ (function () {
     function KnockoutCustomAttribute(element) {
         this.element = element;
     }
@@ -53,10 +53,10 @@ var KnockoutCustomAttribute = (function () {
     KnockoutCustomAttribute.prototype.unbind = function () {
         ko.cleanNode(this.element);
     };
+    KnockoutCustomAttribute = __decorate([
+        aurelia_templating_1.customAttribute('knockout'),
+        aurelia_dependency_injection_1.inject(Element)
+    ], KnockoutCustomAttribute);
     return KnockoutCustomAttribute;
 }());
-KnockoutCustomAttribute = __decorate([
-    aurelia_templating_1.customAttribute('knockout'),
-    aurelia_dependency_injection_1.inject(Element)
-], KnockoutCustomAttribute);
 exports.KnockoutCustomAttribute = KnockoutCustomAttribute;
diff --git a/dist/commonjs/require-polyfill.js b/dist/commonjs/require-polyfill.js
@@ -8,7 +8,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
 Object.defineProperty(exports, "__esModule", { value: true });
 var aurelia_loader_1 = require("aurelia-loader");
 var aurelia_dependency_injection_1 = require("aurelia-dependency-injection");
-var RequirePolyfill = (function () {
+var RequirePolyfill = /** @class */ (function () {
     function RequirePolyfill(loader) {
         this.loader = loader;
     }
@@ -45,9 +45,9 @@ var RequirePolyfill = (function () {
             };
         }
     };
+    RequirePolyfill = __decorate([
+        aurelia_dependency_injection_1.inject(aurelia_loader_1.Loader)
+    ], RequirePolyfill);
     return RequirePolyfill;
 }());
-RequirePolyfill = __decorate([
-    aurelia_dependency_injection_1.inject(aurelia_loader_1.Loader)
-], RequirePolyfill);
 exports.RequirePolyfill = RequirePolyfill;
diff --git a/dist/es2015/knockout-composition.js b/dist/es2015/knockout-composition.js
@@ -159,6 +159,7 @@ let KnockoutComposition = class KnockoutComposition {
                     return result;
                 }
             }
+            this.container.registerTransient(result);
             return this.container.get(result);
         });
     }

diff --git a/dist/es2017/knockout-composition.js b/dist/es2017/knockout-composition.js
@@ -159,6 +159,7 @@ let KnockoutComposition = class KnockoutComposition {
                     return result;
                 }
             }
+            this.container.registerTransient(result);
             return this.container.get(result);
         });
     }

diff --git a/dist/native-modules/knockout-bindable.js b/dist/native-modules/knockout-bindable.js
@@ -8,7 +8,7 @@ import { ObserverLocator } from 'aurelia-binding';
 import { BehaviorPropertyObserver } from 'aurelia-templating';
 import { inject } from 'aurelia-dependency-injection';
 import * as ko from 'knockout';
-var KnockoutBindable = (function () {
+var KnockoutBindable = /** @class */ (function () {
     function KnockoutBindable(observerLocator) {
         this.subscriptions = [];
         this.observerLocator = observerLocator;
@@ -59,9 +59,9 @@ var KnockoutBindable = (function () {
     KnockoutBindable.prototype.getObserver = function (target, key) {
         return this.observerLocator.getObserver(target, key);
     };
+    KnockoutBindable = __decorate([
+        inject(ObserverLocator)
+    ], KnockoutBindable);
     return KnockoutBindable;
 }());
-KnockoutBindable = __decorate([
-    inject(ObserverLocator)
-], KnockoutBindable);
 export { KnockoutBindable };
diff --git a/dist/native-modules/knockout-composition.js b/dist/native-modules/knockout-composition.js
@@ -55,7 +55,7 @@ function processInstruction(instruction) {
 function loadModule(moduleId, loader) {
     return loader.loadModule(moduleId);
 }
-var KnockoutComposition = (function () {
+var KnockoutComposition = /** @class */ (function () {
     function KnockoutComposition(compositionEngine, container, loader) {
         this.compositionEngine = compositionEngine;
         this.container = container;
@@ -163,12 +163,13 @@ var KnockoutComposition = (function () {
                     return result;
                 }
             }
+            _this.container.registerTransient(result);
             return _this.container.get(result);
         });
     };
+    KnockoutComposition = __decorate([
+        inject(CompositionEngine, Container, Loader)
+    ], KnockoutComposition);
     return KnockoutComposition;
 }());
-KnockoutComposition = __decorate([
-    inject(CompositionEngine, Container, Loader)
-], KnockoutComposition);
 export { KnockoutComposition };
diff --git a/dist/native-modules/knockout-custom-attribute.js b/dist/native-modules/knockout-custom-attribute.js
@@ -21,7 +21,7 @@ function getFirstBoundChild(rootNode) {
     }
     return null;
 }
-var KnockoutCustomAttribute = (function () {
+var KnockoutCustomAttribute = /** @class */ (function () {
     function KnockoutCustomAttribute(element) {
         this.element = element;
     }
@@ -51,10 +51,10 @@ var KnockoutCustomAttribute = (function () {
     KnockoutCustomAttribute.prototype.unbind = function () {
         ko.cleanNode(this.element);
     };
+    KnockoutCustomAttribute = __decorate([
+        customAttribute('knockout'),
+        inject(Element)
+    ], KnockoutCustomAttribute);
     return KnockoutCustomAttribute;
 }());
-KnockoutCustomAttribute = __decorate([
-    customAttribute('knockout'),
-    inject(Element)
-], KnockoutCustomAttribute);
 export { KnockoutCustomAttribute };
diff --git a/dist/native-modules/require-polyfill.js b/dist/native-modules/require-polyfill.js
@@ -6,7 +6,7 @@ var __decorate = (this && this.__decorate) || function (decorators, target, key,
 };
 import { Loader } from 'aurelia-loader';
 import { inject } from 'aurelia-dependency-injection';
-var RequirePolyfill = (function () {
+var RequirePolyfill = /** @class */ (function () {
     function RequirePolyfill(loader) {
         this.loader = loader;
     }
@@ -43,9 +43,9 @@ var RequirePolyfill = (function () {
             };
         }
     };
+    RequirePolyfill = __decorate([
+        inject(Loader)
+    ], RequirePolyfill);
     return RequirePolyfill;
 }());
-RequirePolyfill = __decorate([
-    inject(Loader)
-], RequirePolyfill);
 export { RequirePolyfill };
diff --git a/dist/system/knockout-bindable.js b/dist/system/knockout-bindable.js
@@ -24,7 +24,7 @@ System.register(["aurelia-binding", "aurelia-templating", "aurelia-dependency-in
             }
         ],
         execute: function () {
-            KnockoutBindable = (function () {
+            KnockoutBindable = /** @class */ (function () {
                 function KnockoutBindable(observerLocator) {
                     this.subscriptions = [];
                     this.observerLocator = observerLocator;
@@ -75,11 +75,11 @@ System.register(["aurelia-binding", "aurelia-templating", "aurelia-dependency-in
                 KnockoutBindable.prototype.getObserver = function (target, key) {
                     return this.observerLocator.getObserver(target, key);
                 };
+                KnockoutBindable = __decorate([
+                    aurelia_dependency_injection_1.inject(aurelia_binding_1.ObserverLocator)
+                ], KnockoutBindable);
                 return KnockoutBindable;
             }());
-            KnockoutBindable = __decorate([
-                aurelia_dependency_injection_1.inject(aurelia_binding_1.ObserverLocator)
-            ], KnockoutBindable);
             exports_1("KnockoutBindable", KnockoutBindable);
         }
     };

diff --git a/dist/system/knockout-composition.js b/dist/system/knockout-composition.js
@@ -71,7 +71,7 @@ System.register(["knockout", "aurelia-dependency-injection", "aurelia-loader", "
             }
         ],
         execute: function () {
-            KnockoutComposition = (function () {
+            KnockoutComposition = /** @class */ (function () {
                 function KnockoutComposition(compositionEngine, container, loader) {
                     this.compositionEngine = compositionEngine;
                     this.container = container;
@@ -179,14 +179,15 @@ System.register(["knockout", "aurelia-dependency-injection", "aurelia-loader", "
                                 return result;
                             }
                         }
+                        _this.container.registerTransient(result);
                         return _this.container.get(result);
                     });
                 };
+                KnockoutComposition = __decorate([
+                    aurelia_dependency_injection_1.inject(aurelia_templating_1.CompositionEngine, aurelia_dependency_injection_1.Container, aurelia_loader_1.Loader)
+                ], KnockoutComposition);
                 return KnockoutComposition;
             }());
-            KnockoutComposition = __decorate([
-                aurelia_dependency_injection_1.inject(aurelia_templating_1.CompositionEngine, aurelia_dependency_injection_1.Container, aurelia_loader_1.Loader)
-            ], KnockoutComposition);
             exports_1("KnockoutComposition", KnockoutComposition);
         }
     };

diff --git a/dist/system/knockout-custom-attribute.js b/dist/system/knockout-custom-attribute.js
@@ -35,7 +35,7 @@ System.register(["aurelia-dependency-injection", "aurelia-templating", "knockout
             }
         ],
         execute: function () {
-            KnockoutCustomAttribute = (function () {
+            KnockoutCustomAttribute = /** @class */ (function () {
                 function KnockoutCustomAttribute(element) {
                     this.element = element;
                 }
@@ -65,12 +65,12 @@ System.register(["aurelia-dependency-injection", "aurelia-templating", "knockout
                 KnockoutCustomAttribute.prototype.unbind = function () {
                     ko.cleanNode(this.element);
                 };
+                KnockoutCustomAttribute = __decorate([
+                    aurelia_templating_1.customAttribute('knockout'),
+                    aurelia_dependency_injection_1.inject(Element)
+                ], KnockoutCustomAttribute);
                 return KnockoutCustomAttribute;
             }());
-            KnockoutCustomAttribute = __decorate([
-                aurelia_templating_1.customAttribute('knockout'),
-                aurelia_dependency_injection_1.inject(Element)
-            ], KnockoutCustomAttribute);
             exports_1("KnockoutCustomAttribute", KnockoutCustomAttribute);
         }
     };
-Original file line number
+Diff line change
@@ Expand Up / @@ -159,6 +159,7 @@ let KnockoutComposition = class KnockoutComposition { @@
                         return result;
                     }
                 }
+                this.container.registerTransient(result);
                 return this.container.get(result);
             });
         }
@@ Expand Down @@