Updated renderer to Bootstrap 4 #489
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Bootstrap changed the validation classes in version 4, I figured we should update the example bootstrap renderer to properly reflect the changes.
|
|
|
@tomschluter Wow! I'm sorry this PR has sat for so long 😢 I apologize. I'd like to get this in. I'm a bit worried it might break some people and I'm wondering if there's a way to make it a config setting, where the actual class names are based on setting the bootstrap version... I'm not sure how feasible that is. Maybe we should split into two different renderers? We could put the old one in a gist somewhere so people can still get it if they need it and make v4 available out of the box. Thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Bootstrap changed the validation classes in version 4, I figured we should update the example bootstrap renderer to properly reflect the changes.