imageio: WebP import with libwep, and other ported fixes. #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlynxZhou
force-pushed
the
add-webp-reading
branch
3 times, most recently
from
bdd872c to
a9246c0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
AlynxZhou
force-pushed
the
add-webp-reading
branch
2 times, most recently
from
0ab3822 to
eee8608
Compare
|
Hm, please don't merge this PR until I finished changes on desktop entry, because I am planning move desktop entry related changes here into another PR, thanks! |
AlynxZhou
force-pushed
the
add-webp-reading
branch
from
eee8608 to
1dbd8b1
Compare
I removed CMake/desktop entry related commit from this PR (and submit another PR for those), this should have no conflict with master now. |
Mostly ported from darktable-org/darktable. Because we already export webp with libwebp, this won't add new dependency. Also find libwebpmux in CMake module.
Mostly ported from darktable-org/darktable. GraphicsMagick could also import WebP and it's easy to implement.
This makes easier to call importers, and removes a lot of redundant code that already done in importers.
Those files support both HDR and LDR, while we typically treat them as HDR, we need to set them to LDR if detected.
Mostly ported from darktable-org/darktable, the original PR has full explanation about why we need this, see <darktable-org#13210>.
Mostly ported from darktable-org/darktable.
Mostly ported from darktable-org/darktable. Refer to <https://github.com/AOMediaCodec/libavif/wiki/CICP#unspecified>, `BT601` and `BT401BG` here are identical for libavif.
It seems this is not a wrong tag.
libheif could also handle AVIF, this adds the same fix we have in AVIF importer.
There is no direct mapping for P3 with MC, so those values are all not wrong, see <https://github.com/AOMediaCodec/libavif/wiki/CICP#common-cicp-triples>.
As well as AVIF exporter.
Mostly ported from darktable-org/darktable. ImageMagick could also import WebP and it's easy to implement. This also allows ImageMagick to read image profile.
aurelienpierre
force-pushed
the
add-webp-reading
branch
from
1dbd8b1 to
4a6b345
Compare
|
Thanks ! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to backport some fixes. It build and run on my system, but I hardly use this program to process non-RAW images, so if other people get error with this, please @ me.