Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mac os nightly builds #379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jakenvac
Copy link

@jakenvac jakenvac commented Nov 8, 2024

I've managed to get mac os nightly builds working, but with a couple of caveats. (screenshots below)

I'm not really familiar with CMake or how it works so I'm sure this is very hacky. A lot of what I came up with in ci-script-mac.sh was trial and error. Any guidance is much appreciated.

Caveats:

  • Build must be done with ICU disabled due to a version mismatch (I think) between the versions available in brew and what Ansel expects. I'm not sure what the impacts of this being disabled in the build are. Generally the app seems to run and perform as normal.
  • Package signing needs configuring. For now you will have to allow the app to run from within the settings app (see screenshot)
  • Currently only built for arm
  • DMG name needs fixing, currently looks like Ansel--arm64.dmg need to use tag to insert version

Any advice of what else needs to be done to get this merged would be greatly appreciated.

You can see the github action on my fork producing a build here:
https://github.com/jakenvac/ansel/actions/runs/11742245723/job/32712579211

And you can download the release from my fork here:
https://github.com/jakenvac/ansel/releases/download/v0.0.0/Ansel--arm64.dmg

screenshots:
Screenshot 2024-11-08 at 12 03 00
Screenshot 2024-11-08 at 12 03 11

Copy link

sonarqubecloud bot commented Nov 8, 2024

@jakenvac jakenvac marked this pull request as ready for review November 8, 2024 12:49
@mmoqui
Copy link

mmoqui commented Dec 19, 2024

Hi @jakenvac,

In your PR , some shell scripts are modified for only a CI context. But those shell scripts are also used to build by hand a MacOS X package of Ansel. And by modifying only a couple of scripts used in a chain of build, this chain is then broken.

In order to fix this chain, could you please modify also the following scripts in the packaging/macosx/ directory:

  • 1_install_hb_dependencies.sh: replace the installation of ImageMagick by MagickGraphics;
  • 2_build_hb_ansel_custom.sh:
    • update the value of the installDir variable with the new installation directory as used in the 3_make_hb_ansel_package.sh and 4_make_hb_ansel_dmg.sh scripts in the PR: ${scriptDir}/../../install;
    • add the build config parameter -DUSE_ICU=OFF in the cmake statement

@sidney
Copy link

sidney commented Jan 2, 2025

I have submitted PR #391 that fixes the issue with ICU in the Mac build

@jakenvac
Copy link
Author

jakenvac commented Jan 7, 2025

@mmoqui Apologies for the delay in my response, I took some time away over xmas.

Thanks for the feedback, if I can find the time, I will address your comments.

@mmoqui
Copy link

mmoqui commented Jan 16, 2025

Hello @jakenvac,

The PR of @sidney has been merged. Now, as the icu4c library issue has been fixed, once your have some time, could you please accordingly rebase your branch with master and restore the use of the icu4c lib in your fix (id est no need to add -DUSE_ICU=OFF in the cmake statement) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants