Refactor to satisfy compiler on string manipulation#506
Merged
aurelienpierre merged 1 commit intoaurelienpierreeng:masterfrom Apr 9, 2025
Merged
Refactor to satisfy compiler on string manipulation#506aurelienpierre merged 1 commit intoaurelienpierreeng:masterfrom
aurelienpierre merged 1 commit intoaurelienpierreeng:masterfrom
Conversation
- "filename_size" renamed to "filename_len" because "size" supposes it includes the null terminating char (as sizeof() would do), but strlen() doesn't. - PATH_MAX includes null terminating char, so we need to compare >=. - Adding \0 at the end of a string is redundant. - g_snprintf() lets us manipulate string without overflow and always terminate with \0 even if the source is longer than the target.
aurelienpierre
force-pushed
the
better_str
branch
from
c550785 to
0301937
Compare
Collaborator
|
Thanks ! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filename_sizerenamed tofilename_lenbecausesizesupposes it includes the null terminating char (as sizeof() would do), but strlen() doesn't.PATH_MAXincludes null terminating char, so we need to see if the string length will be greater or equal.Adding
\0at the end of strings we are initializing is redundant.g_snprintf() lets us manipulate string securely, without overflow and always terminate with
\0even if the source is longer than the target.