fix: kwarg LlamaCppLLM.llm overwritten by import #211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #206 .
Description of fix
A bug was introduced in #190 that overwrote the kwarg value of
LlamaCppLLM.llm
, replacing a passed kwarg instance ofllama_cpp.Llama
.The same bug also replaced the passed value of
LlamaCppLLM.grammar
.Fix
Rely on
self._llama_cpp.{Llama,LlamaGrammar}
if we need these classes, remove the overriding ofllm
andgrammar
from the values passed as kwargs.