fix: status message typo & outdated error #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* typo: transfering -> transferring * outdated error: referencing "Lock" step instead of "Transfer" step The outdated error message made me realize that the error messages were not included in the i18n, so I added them there and added a helper to `client/i18nHelpers` to access it.
chadoh
commented
Apr 1, 2021
|
|
||
| // get available & fallback locale from given i18n | ||
| const availableLocales = Object.keys(i18n) | ||
| const fallback = availableLocales[0] as string |
There was a problem hiding this comment.
Should probably fall back to something that matches the first part of locale here. So if no es_MX but there is an es_ES, use es_ES.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outdated error message made me realize that the error messages were not included in the i18n, so I added them there and added a helper to
client/i18nHelpersto access it.