perf: make Stack::peek() return a reference #12
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies
Stack::peek()
to return a reference, i.e.&U256
instead ofU256
.Since
U256
derivesCopy
, call sites which need to own to the value returnedby
peek
may dereference to create a copy:Regarding
Stack::peek_h256()
: I think theH256
value must be constructedinside the function and since it's not possible to return a reference to a local
variable,
peek_h256
cannot return a reference&H256
. If I'm missingsomething here, please let me know!
The steps mentioned here under
Reproduction
can be taken to benchmarkthis change in
aurora-engine
.Ref: #448