-
Notifications
You must be signed in to change notification settings - Fork 0
UPSTREAM PR #17344: ggml-hexagon: fix swiglu failure at test-backend-ops
#247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DajanaV
wants to merge
24
commits into
main
Choose a base branch
from
upstream-PR17344-branch_chraac-dev-fix-swiglu
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+99
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d_inf for improved overflow handling
f333350 to
9c4623f
Compare
64f477c to
7c4fc52
Compare
ad5ad9a to
aaa8a85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#17344
Fixes some failure on the Hexagon
swiglu/siluop and improves correctness of the GGML Hexagon backend.Summary of changes
hvx_vec_exp_fp32_guard,hvx_vec_inverse_fp32_guard) and use them in the Hexagon backend.NaN/Infhandling inexp,inverse, and related helper func.Before
After