Skip to content

fix: suppress false-positive deprecation warning for cross_origin_auth when using cross_origin_authentication #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ankita10119 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: suppress false-positive deprecation warning for cross_origin_auth when using cross_origin_authentication #1322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e87d763
fix: update sanitizeCrossOriginAuth to accept warning parameter
ankita10119 Mar 12, 2026
e6ab9ff
Merge branch 'master' into DXCDT-1510
ankita10119 Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/tools/auth0/handlers/clients.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,15 +345,15 @@ export type Client = Management.Client;

type ClientSanitizerChain = {
sanitizeOidcLogout(): ClientSanitizerChain;
sanitizeCrossOriginAuth(): ClientSanitizerChain;
sanitizeCrossOriginAuth(warn?: boolean): ClientSanitizerChain;
get(): Client[];
};

const createClientSanitizer = (clients: Client[]): ClientSanitizerChain => {
let sanitized = clients;

return {
sanitizeCrossOriginAuth() {
sanitizeCrossOriginAuth(warn = true) {
const deprecatedClients: string[] = [];

sanitized = sanitized.map((client) => {
Expand All @@ -373,7 +373,7 @@ const createClientSanitizer = (clients: Client[]): ClientSanitizerChain => {
return updated;
});

if (deprecatedClients.length > 0) {
if (warn && deprecatedClients.length > 0) {
log.warn(
"The 'cross_origin_auth' parameter is deprecated in clients and scheduled for removal in future releases.\n" +
`Use 'cross_origin_authentication' going forward. Clients using the deprecated setting: [${deprecatedClients.join(
Expand Down Expand Up @@ -524,7 +524,7 @@ export default class ClientHandler extends DefaultAPIHandler {
...(shouldExcludeThirdPartyClients(this.config) && { is_first_party: true }),
});

this.existing = createClientSanitizer(clients).sanitizeCrossOriginAuth().get();
this.existing = createClientSanitizer(clients).sanitizeCrossOriginAuth(false).get();
return this.existing;
}

Expand Down