Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return assets from exported functions #871

Closed
wants to merge 2 commits into from

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Dec 4, 2023

🔧 Changes

The CLI can be consumed as a node module. When currently invoked as such, there are no return values. This PR introduces the returning of the assets object on both import and export. This attempts to provide some useful information for the user to potentially act on or use to verify the expected results.

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fa738a5) 84.23% compared to head (c858674) 84.19%.

Files Patch % Lines
src/commands/export.ts 50.00% 1 Missing ⚠️
src/commands/import.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
- Coverage   84.23%   84.19%   -0.05%     
==========================================
  Files         115      115              
  Lines        3610     3612       +2     
  Branches      700      700              
==========================================
  Hits         3041     3041              
- Misses        324      326       +2     
  Partials      245      245              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willvedd willvedd closed this Dec 22, 2023
@willvedd willvedd deleted the return-assets-object-node-module branch December 22, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants