Skip to content

Commit

Permalink
Use node 20 for vue-cli test (#1169)
Browse files Browse the repository at this point in the history
<!-- By submitting a PR to this repository, you agree to the terms
within the [Auth0 Code of
Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md).
Please see the [contributing
guidelines](https://github.com/auth0/.github/blob/master/CONTRIBUTING.md)
for how to create and submit a high-quality PR for this repo. -->

### Changes

It seems there's an issue with 18.18 that is causing the build to hang,
moving to 20 fixes this, check the various test performed in the
[actions tab](https://github.com/auth0/auth0-spa-js/actions)

### References

<!--
Please include relevant links supporting this change such as a:

- support ticket
- community post
- StackOverflow post
- support forum thread

Please note any links that are not publicly accessible.
-->

### Testing

<!--
Please describe how this can be tested by reviewers. Be specific about
anything not tested and reasons why. If this library has unit and/or
integration testing, tests should be added for new functionality and
existing tests should complete without errors.
-->

- [ ] This change adds unit test coverage
- [ ] This change adds integration test coverage
- [ ] This change has been tested on the latest version of the
platform/language

### Checklist

- [x] I have read the [Auth0 general contribution
guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md)
- [x] I have read the [Auth0 Code of
Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md)
- [x] All code quality tools/guidelines have been run/followed
  • Loading branch information
ewanharris authored Oct 2, 2023
1 parent a5583e3 commit 1600945
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,10 @@ jobs:
- name: Run framework tests
uses: ./.github/actions/framework
with:
node: ${{ env.NODE_VERSION }}
node: 20
cache: ${{ env.CACHE_KEY }}
install: |
npx -p @vue/cli vue create my-app -d < /dev/null
npx -p @vue/cli vue create my-app -d --packageManager npm < /dev/null
content: |
echo -e "${{ env.AUTH0_CONTENT }}" > src/auth0.js;
import: |
Expand Down

0 comments on commit 1600945

Please sign in to comment.