Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acul implementation #1060

Merged
merged 1 commit into from
Dec 9, 2024
Merged

acul implementation #1060

merged 1 commit into from
Dec 9, 2024

Conversation

tusharpandey13
Copy link
Contributor

@tusharpandey13 tusharpandey13 commented Nov 25, 2024

Updated PromptsManager with 2 new methods:

Path HTTP Method Method Name
/prompts/{prompt}/screen/{screen}/rendering GET getRendering
/prompts/{prompt}/screen/{screen}/rendering PATCH updateRendering

also added unit tests for the same.

References

Docs are not public yet for this feature. Will update here once they are released in EA/GA.

Testing

We will release guides to use this features separately that can help in manual testing.

Test Suites: 43 passed, 43 total
Tests:       1421 passed, 1421 total
Snapshots:   0 total
Time:        7.338 s, estimated 8 s
Ran all test suites.
  • This change adds unit test coverage
  • This change adds integration test coverage

Checklist

@tusharpandey13 tusharpandey13 requested a review from a team as a code owner November 25, 2024 10:57
@tusharpandey13 tusharpandey13 changed the title acul initial implementation with unit tests written in the new format acul implementation Dec 9, 2024
@tusharpandey13 tusharpandey13 merged commit a7d0870 into master Dec 9, 2024
4 checks passed
@tusharpandey13 tusharpandey13 deleted the feature/acul branch December 9, 2024 07:04
@tusharpandey13 tusharpandey13 mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants