feat: Add experimental count relationships by filter to Materialize API #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephschorr
force-pushed
the
materialize-relationships
branch
2 times, most recently
from
ea11803 to
f5fb9ba
Compare
josephschorr
force-pushed
the
materialize-relationships
branch
from
f5fb9ba to
9eb6e4a
Compare
miparnisari
reviewed
Oct 17, 2025
|
|
||
| message ExperimentalCountRelationshipsByFilterResponse { | ||
| // relationship_count is the count of relationships that match the filter. | ||
| uint64 relationship_count = 1; |
There was a problem hiding this comment.
why does this not have the required tags?
There was a problem hiding this comment.
I generally don't mark required on response types and basically forgot to do so; it will auto-fill to zero anyway as an int, so marking it required doesn't really make sense
miparnisari
reviewed
Oct 17, 2025
| } | ||
| } | ||
| }, | ||
| "ExperimentalCountRelationshipsByFilterResponse": { |
There was a problem hiding this comment.
This swagger looks odd; is it including ALL the Materialize stuff? it doesn't look like it
why did it include this response object and not the API itself?
There was a problem hiding this comment.
Ahh it's because of this line
Line 10 in 3454618
There was a problem hiding this comment.
Yeah, although it doesn't really matter either way
vroldanbet
approved these changes
Oct 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new experimental count relationships API that can be run on the Materialize instance, to avoid performing the count on the main datastore