Change PG and CRDB datastore drivers to use PGX cancelation #2294
+73
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should (in most cases) allow the connection to be reused when the parent context is canceled, instead of our current behavior of severing the context and allowing the query to finish processing. Severing was initially done because the default behavior in PGX is to *close* the connection, which added overhead on other requests
Since locks are per connection/session, the connection used by GC must be the same one
github-actions
bot
added
the
area/tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should (in most cases) allow the connection to be reused when the parent context is canceled, instead of our current behavior of severing the context and allowing the query to finish processing. Severing was initially done because the default behavior in PGX is to close the connection, which added overhead on other requests