chore: reduce chance of flakiness on the migrate integration test #2674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds retries and increases the wait timeout for the migration call
github-actions
bot
added
area/cli
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2674 +/- ##
==========================================
- Coverage 79.46% 79.45% -0.00%
==========================================
Files 455 455
Lines 47161 47161
==========================================
- Hits 37470 37467 -3
+ Misses 6945 6944 -1
- Partials 2746 2750 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miparnisari
reviewed
Nov 7, 2025
| } | ||
| require.NoError(t, err) | ||
|
|
||
| waitCtx, cancel := context.WithTimeout(context.Background(), 5*time.Second) |
Contributor
There was a problem hiding this comment.
why do we even have a timeout here..? i say let the thing take as long as it wants: remove the retry stuff and the waitCtx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds retries and increases the wait timeout for the migration call