Add MustSafecast helper for type conversions #2730
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds MustSafecast function following the MustBugf pattern: - Panics in tests when conversion fails - Returns zero value in production with warning log - Replaces manual safecast error handling across codebase Closes authzed#2714
github-actions
bot
added
area/schema
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2730 +/- ##
==========================================
+ Coverage 77.01% 77.05% +0.05%
==========================================
Files 462 464 +2
Lines 49121 49181 +60
==========================================
+ Hits 37825 37892 +67
+ Misses 8509 8506 -3
+ Partials 2787 2783 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
The failing CRDB 25.2.0 consistency test doesn't look related to the MustSafecast changes. The error is a database timeout: CRDB 25.3.0 passes, as do all other datastores. Seems like a CRDB 25.2.0-specific issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a
MustSafecasthelper function to the spiceerrors package that panics on cast failure, complementing the existingSafecastfunction.Fixes #2714
Changes
MustSafecast[I, O]function inpkg/spiceerrors/safecast.go.gitignoreto properly ignore__pycache__/directories