perms: add support for cursor and show-cursor flags in lookup resources#485
Merged
tstirrat15 merged 2 commits intoauthzed:mainfrom Apr 22, 2025
Merged
Conversation
kartikaysaxena
changed the title
tstirrat15
reviewed
Apr 21, 2025
Contributor
tstirrat15
left a comment
tstirrat15
left a comment
There was a problem hiding this comment.
See comments - I'll re-review after that
Comment on lines
+530
to
+533
| showCursor := cobrautil.MustGetBool(cmd, "show-cursor") | ||
| if showCursor && cursor != nil { | ||
| console.Printf("Last cursor: %s\n", cursor.Token) | ||
| } |
Contributor
There was a problem hiding this comment.
Can we change the logic to set show-cursor to true by default, and show the cursor if one exists by default?
I think it'll be more useful to show it if it's available, unless the user explicitly says not to. I chatted with the issue reporter about this and we're in agreement there.
Contributor
Author
There was a problem hiding this comment.
sure, would be handy, defaulting the flag to be true unless explicitly set to false
Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
kartikaysaxena
force-pushed
the
support-cursor-for-lookup-resources
branch
from
d19a6ef to
874e0ea
Compare
tstirrat15
approved these changes
Apr 22, 2025
Contributor
tstirrat15
left a comment
tstirrat15
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you!
Contributor
|
That test looks like a potential flake - I'll look into it if it fails again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #482
Adds support for displaying the last cursor when the user opts in a
show-cursorflag, also allows user to use a custom cursor to resume browsing the pages from a specific state using acursorflag