Skip to content

fix(deps): update dependency get-port to v7 #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2025
Merged

fix(deps): update dependency get-port to v7 #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acf93a0
fix(deps): update dependency get-port to v7
renovate[bot] Jan 23, 2025
ada0b4d
dynamic import ESM module get-port
austin-autify Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"abort-controller": "^3.0.0",
"archiver": "^6.0.2",
"envfile": "^7.1.0",
"get-port": "^5.1.1",
"get-port": "^7.1.0",
"inquirer": "^8.2.6",
"listr": "^0.14.3",
"node-emoji": "^2.1.3",
Expand Down
13 changes: 12 additions & 1 deletion src/autify/connect/client-manager/ClientManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,19 @@ import {
} from "./Logger";
import { join } from "node:path";
import TypedEmitter from "typed-emitter";
import getPort from "get-port";
import { getWebClient } from "../../web/getWebClient";
import { parse } from "shell-quote";
import type GetPort from "get-port";

// Workaround to import get-port, which is an ES module, dynamically and avoid
// having typescript transpile that import into a require.
async function importGetPort(): Promise<typeof GetPort> {
// eslint-disable-next-line @typescript-eslint/no-unused-vars
return new Promise((resolve) => {
// eslint-disable-next-line no-eval
eval(`import("get-port").then((esm) => resolve(esm.default));`);
});
}

export type ClientEvents = TypedEmitter<{
log: (msg: string) => void;
Expand Down Expand Up @@ -108,6 +118,7 @@ export class ClientManager {
try {
this.logger.debug("start");
const version = await this.getClientVersion();
const getPort = await importGetPort();
const debugServerPort = this.options.debugServerPort ?? (await getPort());
this.logger.info(
`Starting Autify Connect Client (accessPoint: ${this.accessPointName}, debugServerPort: ${debugServerPort}, path: ${this.clientPath}, version: ${version})`
Expand Down
Loading