New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/mocks: update newsletter items list to computed value to show dynamically translated labels #915

Merged

tmszi merged 2 commits into auto-mat:main from maceksimon:feature/newsletter-labels

Feb 11, 2025

Contributor

maceksimon commented Feb 10, 2025

Issue: When switching between languages on homepage, labels for different newsletter subscriptions do not change and only show in Czech language.

Solution: Change the newsletter items list to computed value to update on language change.

Update the NewsletterItem type, which should no longer contain the following property.
Simplify the newsletterItems import in NewsletterFeature component.
Update NewsletterItem.cy.js component test to use the .value of the computed ref.
Add E2E test which validates correct language of labels when given locale is selected.


          update newsletter items list to computed value

16e08d5

tmszi added the bug label

tmszi approved these changes

View reviewed changes

tmszi merged commit 24ea3af into auto-mat:main

0 of 6 checks passed


          src/components/__tests__: extend NewsletterItem component tests

a8bd50e

By testing changing localization lang to the EN lang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug