Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-Chain PCCS Audit Submission For Release (November 2024) #9

Merged
merged 25 commits into from
Nov 20, 2024

Conversation

preston4896
Copy link
Collaborator

@preston4896 preston4896 commented Nov 8, 2024

Overview

New changes included in this PR that we are planning to roll out for the next release of both Automata On-Chain PCCS and Automata DCAP Attestation.

Major change(s) included in this PR:

  • Dynamic P256 Verifier configuration upon deployment. See relevant changes:
    ad672b9
    70c4032

  • Improved collateral data management, using the IDaoAttestationResolver interface. See relevant changes:
    a25d208
    376b1e3

  • temporary caller restriction for reading collaterals from PCCS, see relevant changes:
    8f73ebe
    a103fc1
    1a389e1
    30301fa

When auditing is in progress, expect the following:

  • Upon finalization of this PR (Converted to Ready To Review status), there shall be no more major breaking changes introduced to this PR. (e.g. external API changes)
  • Code optimizations may require minor changes on internal methods.
  • Revision(s) that may be necessary based on findings from auditing. (May be exempted from the "no breaking changes" rule)

@preston4896 preston4896 changed the title On-Chain PCCS Audit Submission For V1.0.0 Release (November 2024) On-Chain PCCS Audit Submission For Release (November 2024) Nov 8, 2024
src/automata_pccs/AutomataPcsDao.sol Outdated Show resolved Hide resolved
src/automata_pccs/shared/AutomataDaoStorage.sol Outdated Show resolved Hide resolved
src/bases/EnclaveIdentityDao.sol Outdated Show resolved Hide resolved
src/automata_pccs/AutomataPcsDao.sol Outdated Show resolved Hide resolved
src/automata_pccs/shared/AutomataDaoStorage.sol Outdated Show resolved Hide resolved
src/bases/EnclaveIdentityDao.sol Outdated Show resolved Hide resolved
src/bases/FmspcTcbDao.sol Outdated Show resolved Hide resolved
@preston4896 preston4896 marked this pull request as ready for review November 19, 2024 02:38
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

src/automata_pccs/shared/AutomataDaoStorage.sol Dismissed Show resolved Hide resolved
src/automata_pccs/shared/AutomataDaoStorage.sol Dismissed Show dismissed Hide dismissed
src/automata_pccs/shared/AutomataDaoStorage.sol Dismissed Show dismissed Hide dismissed
src/bases/DaoBase.sol Fixed Show fixed Hide fixed
src/bases/DaoBase.sol Dismissed Show dismissed Hide dismissed
src/bases/PckDao.sol Dismissed Show dismissed Hide dismissed
src/bases/PckDao.sol Dismissed Show dismissed Hide dismissed
src/bases/PcsDao.sol Dismissed Show dismissed Hide dismissed
src/bases/PcsDao.sol Dismissed Show dismissed Hide dismissed
src/utils/P256Verifier.sol Dismissed Show dismissed Hide dismissed
@preston4896 preston4896 merged commit 00ca286 into main Nov 20, 2024
3 checks passed
@preston4896 preston4896 deleted the DEV-3373/audit branch November 20, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants