Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor web server setup + proxy /metrics to pushgateway #81

Merged
merged 5 commits into from
Jul 11, 2023
Merged

Refactor web server setup + proxy /metrics to pushgateway #81

merged 5 commits into from
Jul 11, 2023

Conversation

mellowagain
Copy link
Member

@mellowagain mellowagain commented Jul 10, 2023 •
edited
Loading

fixes #63

  • Changelog updated

@mellowagain mellowagain requested a review from a team as a code owner July 10, 2023 13:44
hatchan
hatchan approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@hatchan hatchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder if we shouldn't make the server module part of the start module, since it is/should only be used from that command, but this is fine for now.

@mellowagain mellowagain merged commit e84d875 into main Jul 11, 2023
@mellowagain mellowagain deleted the server-refactor branch July 11, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hatchan hatchan hatchan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forward call to /metrics to pushgateway if pushgateway is enabled
2 participants
@mellowagain @hatchan