Skip to content

Commit

Permalink
Add copyright and license template into tp-libvirt_review_comment_sum…
Browse files Browse the repository at this point in the history
…mary.rst

This is one good practice when contributing to upstream

Signed-off-by: chunfuwen <[email protected]>
  • Loading branch information
chunfuwen committed Apr 6, 2023
1 parent 9d6059a commit aad6b04
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions tp-libvirt_review_comment_summary.rst
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,21 @@ Coding

- focus on the problem to be solved now, not speculated one that might need to be solved in the future; the future problem should be solved once it arrives and you can see its actual shape and requirements in the physical universe

- copyright and license template when submitting new python file

- For newly submitted PR, if there is new python file created from this PR, please add below information at the beginning of python file:
#
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#
# Copyright xx(company name)
#
# SPDX-License-Identifier: GPL-2.0

# Author: xx<[email protected]> (name + email addres)
#
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


======================================================================
Enhancement (best practice):
======================================================================
Expand Down

0 comments on commit aad6b04

Please sign in to comment.