Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virsh_migrate_stress: perform migration with macvtap hotplug/coldplug #2064

Closed
wants to merge 1 commit into from

Conversation

balamuruhans
Copy link
Member

@balamuruhans balamuruhans commented Mar 5, 2019

This patch adds tests that could perform migration with macvtap
interface attached to VMs. pre-requisite is to have physical cards
attached in the same slots in source and target host so that the
Virtual Functions(VFs) created out of Physical Functions(PFs) will
be identical for VMs migrate.

This patch removes couple of trivial scenarios that can be tested
by overriding the smp and mem params from config instead.

Signed-off-by: Balamuruhan S [email protected]

@balamuruhans
Copy link
Member Author

depends on: avocado-framework/avocado-vt#1985

@balamuruhans
Copy link
Member Author

depends on: avocado-framework/avocado-vt#2042

@balamuruhans
Copy link
Member Author

@dzhengfy please help to review.

libvirt/tests/src/virsh_cmd/domain/virsh_migrate_stress.py Outdated Show resolved Hide resolved
pf_vf_info = source_assignable.get_pf_vf_info()
# map vf from each pf to every VM
for vm_index in range(len(vms)):
iface_list = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if there is a possibility of abstracting to config like if applicable

  1. one vfs from all pfs to all vms
  2. all vfs of one pf to each vm( helpful incase of single vm)
  3. all vfs of all pfs to one vm

Copy link
Member Author

@balamuruhans balamuruhans Jul 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add these as new scenarios in my next PR.

vstress[vm.name].unload_stress()
except KeyError:
continue
# bring down the VMs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can skip and leave it postprocess based on the config setting?, what say

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, these tests would run stress tools inside VM, bringing down the VMs here will actually cleans up all of it, because sometimes after test completes it takes more time for VM to respond in login, kill the stress process and clean up due to the stress load running inside VM. It is better not to waste test time instead bring down the VM will helps us save it.

@balamuruhans
Copy link
Member Author

@sathnaga I have made the changes as suggested.

This patch adds tests that could perform migration with macvtap
interface attached to VMs. pre-requisite is to have physical cards
attached in the same slots in source and target host so that the
Virtual Functions(VFs) created out of Physical Functions(PFs) will
be identical for VMs migrate.

This patch removes couple of trivial scenarios that can be tested
by overriding the `smp` and `mem` params from config instead.

Signed-off-by: Balamuruhan S <[email protected]>
@dzhengfy
Copy link
Contributor

dzhengfy commented Sep 3, 2021

After confirmation with the IBM PPC FVT lead that the author does not work on this any more and the pr is not in use by them. So I close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants