passt/function: fix for multi-arch #5382
Conversation
|
Expect checks to pass after dependency has been merged. |
| tcp_port_list = [f'{host_ip}%{vm_iface}:31339', f'[{host_ip_v6}]%{vm_iface}:51339'] | ||
| udp_port_list = [f'{host_ip}%{vm_iface}:2025'] | ||
| tcp_port_list = [f'{host_ip}%{host_iface}:31339', f'[{host_ip_v6}]%{host_iface}:51339'] | ||
| udp_port_list = [f'{host_ip}%{host_iface}:2025'] |
| state="UP")[0] | ||
| host_ip = utils_net.get_ip_address_by_interface(host_iface, ip_ver='ipv4') | ||
| host_ip_v6 = utils_net.get_ip_address_by_interface(host_iface, ip_ver='ipv6') | ||
| params['host_ip_v6'] = host_ip_v6 |
There was a problem hiding this comment.
Maybe we can check the interface xml first, if the "dev" is specified, use it directly. If it is null, try to get the host_iface then. And for the host_ip_v6, if the host interface has 2 global ipv6 addresses(like in your test env.), it will use the more specific one - the one got by dhcp with prefix length as 128. Do we need to add some check here?
There was a problem hiding this comment.
Maybe we can check the interface xml first, if the "dev" is specified, use it directly.
I don't understand. The host_iface value would be used later to set the dev value l. 86.
if the host interface has 2 global ipv6 addresses(like in your test env.), it will use the more specific one - the one got by dhcp with prefix length as 128. Do we need to add some check here?
At this point, I have a test environment like on x86_64 without dhcp. Therefore the check is not needed IMO.
There was a problem hiding this comment.
The host_iface value would be used later to set the dev value l. 86.
Oh, sorry, I misunderstood it.
At this point, I have a test environment like on x86_64 without dhcp. Therefore the check is not needed IMO.
Okay, then it should work properly.
smitterl
force-pushed
the
passt_function
branch
from
871da5f to
f3abbe4
Compare
1. Configure values for s390x 2. Get IP addresses by host interface to avoid issues when there's more than one functional NIC. 3. Use the host_iface in several functions to make sure the right interface is tested. 4. The test needs to check the ports on the host not in the guest. Therefore, configure the host_iface. Signed-off-by: Sebastian Mitterle <[email protected]>
smitterl
force-pushed
the
passt_function
branch
from
f3abbe4 to
c2dc141
Compare
Depends on #5361