Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing "U" flag as it is removed from Python3.11! #5390

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removing "U" flag as it is removed from Python3.11! #5390

wants to merge 1 commit into from

Conversation

Anushree-Mathur
Copy link
Contributor

@Anushree-Mathur Anushree-Mathur commented Jan 16, 2024 •
edited
Loading

"U" flag was deprecated since Python3.3 but has been removed from Python3.11. This "universal newline" mode is by default enabled whenever a file is opened in text mode. For reference : https://docs.python.org/3/whatsnew/3.11.html
Signed-off-by: Anushree Mathur [email protected]

@Anushree-Mathur
Removing "U" flag as it is removed from Python3.11!
82e02e2 
"U" flag was deprecated since Python3.3 but has been removed from Python3.11. This "universal newline" mode is by default enabled whenever a file is opened in text mode.
For reference : https://docs.python.org/3/whatsnew/3.11.html
Signed-off-by: Anushree Mathur <[email protected]>
@Anushree-Mathur
Copy link
Contributor Author

Anushree-Mathur commented Jan 16, 2024 •
edited
Loading

Before applying patch :

(2/8) type_specific.io-github-autotest-libvirt.virsh.emulatorpin.positive_testing.set_emulatorpin_parameter.running_guest.cpulist.emulatorpin_options.live.comma_list: ERROR: invalid mode: 'rU' (8.67 s)
 (3/8) type_specific.io-github-autotest-libvirt.virsh.emulatorpin.positive_testing.set_emulatorpin_parameter.running_guest.cpulist.emulatorpin_options.live.single.default: STARTED
 (3/8) type_specific.io-github-autotest-libvirt.virsh.emulatorpin.positive_testing.set_emulatorpin_parameter.running_guest.cpulist.emulatorpin_options.live.single.default: ERROR: invalid mode: 'rU' (8.57 s)

 (5/8) type_specific.io-github-autotest-libvirt.virsh.emulatorpin.positive_testing.set_emulatorpin_parameter.running_guest.cpulist.emulatorpin_options.current.comma_list: STARTED
 (5/8) type_specific.io-github-autotest-libvirt.virsh.emulatorpin.positive_testing.set_emulatorpin_parameter.running_guest.cpulist.emulatorpin_options.current.comma_list: ERROR: invalid mode: 'rU' (8.59 s)
 (6/8) type_specific.io-github-autotest-libvirt.virsh.emulatorpin.positive_testing.set_emulatorpin_parameter.running_guest.cpulist.emulatorpin_options.current.single.default: STARTED
 (6/8) type_specific.io-github-autotest-libvirt.virsh.emulatorpin.positive_testing.set_emulatorpin_parameter.running_guest.cpulist.emulatorpin_options.current.single.default: ERROR: invalid mode: 'rU' (8.29 s) ```

@Anushree-Mathur
Copy link
Contributor Author

After applying patch:

(2/8) type_specific.io-github-autotest-libvirt.virsh.emulatorpin.positive_testing.set_emulatorpin_parameter.running_guest.cpulist.emulatorpin_options.live.comma_list: STARTED
 (2/8) type_specific.io-github-autotest-libvirt.virsh.emulatorpin.positive_testing.set_emulatorpin_parameter.running_guest.cpulist.emulatorpin_options.live.comma_list: PASS (8.34 s)
 (3/8) type_specific.io-github-autotest-libvirt.virsh.emulatorpin.positive_testing.set_emulatorpin_parameter.running_guest.cpulist.emulatorpin_options.live.single.default: STARTED
 (3/8) type_specific.io-github-autotest-libvirt.virsh.emulatorpin.positive_testing.set_emulatorpin_parameter.running_guest.cpulist.emulatorpin_options.live.single.default: PASS (8.73 s)

 (5/8) type_specific.io-github-autotest-libvirt.virsh.emulatorpin.positive_testing.set_emulatorpin_parameter.running_guest.cpulist.emulatorpin_options.current.comma_list: STARTED
 (5/8) type_specific.io-github-autotest-libvirt.virsh.emulatorpin.positive_testing.set_emulatorpin_parameter.running_guest.cpulist.emulatorpin_options.current.comma_list: PASS (8.50 s)
 (6/8) type_specific.io-github-autotest-libvirt.virsh.emulatorpin.positive_testing.set_emulatorpin_parameter.running_guest.cpulist.emulatorpin_options.current.single.default: STARTED
 (6/8) type_specific.io-github-autotest-libvirt.virsh.emulatorpin.positive_testing.set_emulatorpin_parameter.running_guest.cpulist.emulatorpin_options.current.single.default: PASS (8.73 s)

sacsant
sacsant reviewed Jan 29, 2024
View reviewed changes
Copy link

@sacsant sacsant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Anushree-Mathur
Copy link
Contributor Author

Can anyone please review this PR and merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sacsant sacsant sacsant left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anushree-Mathur @sacsant