memory: Increase guest memory to 4G #5397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All setmem cases passed. |
chunfuwen
reviewed
Jan 25, 2024
| @@ -251,6 +251,10 @@ def print_debug_stats(original_inside_mem, original_outside_mem, | |||
| vmxml = vm_xml.VMXML.new_from_inactive_dumpxml(vm_name) | |||
| backup_xml = vmxml.copy() | |||
|
|
|||
| vm_attrs = eval(params.get('vm_attrs')) | |||
There was a problem hiding this comment.
Perhaps, we may add some pre-check for host whether there is 4G memory available at that time. Otherwise just skip this case
hs0210
force-pushed
the
memory_increase
branch
from
a3665e3 to
3e71098
Compare
dzhengfy
reviewed
Feb 21, 2024
| @@ -17,6 +17,7 @@ | |||
| # expected to fail on older libvirt. | |||
| setmem_old_libvirt_fail = "no" | |||
| take_regular_screendumps = no | |||
| vm_attrs = {'memory': 4, 'memory_unit': 'GiB', 'current_mem': 4, 'current_mem_unit': 'GiB'} | |||
There was a problem hiding this comment.
The virsh_cmd folder will be deprecated. We plan to make inside cases into corresponding feature folder. So could you please move the cfg and py files into libvirt/tests/cfg/memory/ and libvirt/tests/src/memory/ folders?
hs0210
force-pushed
the
memory_increase
branch
from
3e71098 to
d4f3387
Compare
The previous guest memory setting was 2G, but the half memory test would fail because 1G was not enough to maintain the normal operation of the guest. Signed-off-by: Hu Shuai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous guest memory setting was 2G, but the half memory test would fail because 1G was not enough to maintain the normal operation of the guest.
Before:
After: