Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove existing interfaces when testing timer #5414

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Remove existing interfaces when testing timer #5414

merged 1 commit into from
Jan 26, 2024

Conversation

iccaszhulili
Copy link
Contributor

Since RHEL8, the NTP protocol is implemented only by the chronyd daemon, which is enabled by default. Remove guest interface to prevent network connection, then guest will not sync time automatically to ntp server after boot. Otherwise, guest time will be synced to current real time regardless of guest configurations.

@iccaszhulili
Copy link
Contributor Author

iccaszhulili commented Jan 26, 2024 •
edited
Loading

# avocado run --vt-type libvirt timer_management
JOB ID : d9f3b934b70947454374d5ff2eb1bc661d2c5ed9
JOB LOG : /var/lib/avocado/job-results/job-2024-01-26T13.45-d9f3b93/job.log
(01/59) type_specific.io-github-autotest-libvirt.timer_management.no_timer.offset_utc.under_stress.stress_in_vm.memory.test_timers_in_vm.linux_guest: STARTED
(01/59) type_specific.io-github-autotest-libvirt.timer_management.no_timer.offset_utc.under_stress.stress_in_vm.memory.test_timers_in_vm.linux_guest: PASS (187.74 s)
......
(59/59) type_specific.io-github-autotest-libvirt.timer_management.specific_timer.platform.present_yes.offset_localtime.no_stress.test_specific_timer: STARTED
(59/59) type_specific.io-github-autotest-libvirt.timer_management.specific_timer.platform.present_yes.offset_localtime.no_stress.test_specific_timer: PASS (31.55 s)
RESULTS : PASS 59 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /var/lib/avocado/job-results/job-2024-01-26T13.45-d9f3b93/results.html
JOB TIME : 10106.41 s

@iccaszhulili iccaszhulili force-pushed the timer_remove_interface branch from 70d8643 to 024bcc6 Compare January 26, 2024 08:16
@iccaszhulili
Copy link
Contributor Author

@Yingshun Please help to check. Thanks

@iccaszhulili iccaszhulili changed the title Remove existing interfaces when testing clock time Remove existing interfaces when testing timer Jan 26, 2024
@iccaszhulili
Remove existing interfaces when testing timer
b284d75 
Since RHEL8, the NTP protocol is implemented only by the chronyd
daemon, which is enabled by default. Remove guest interface to
prevent network connection, then guest will not sync time automatically
to ntp server after boot. Otherwise, guest time will be synced to
current real time regardless of guest configurations.

Signed-off-by: Lili Zhu <[email protected]>
@iccaszhulili iccaszhulili force-pushed the timer_remove_interface branch from 024bcc6 to b284d75 Compare January 26, 2024 08:26
Yingshun
Yingshun approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@Yingshun Yingshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chloerh chloerh merged commit 66086ab into autotest:master Jan 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yingshun Yingshun Yingshun approved these changes

@chloerh chloerh chloerh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iccaszhulili @chloerh @Yingshun