Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto_nodedev: improve reliability #5415

Merged
merged 1 commit into from
Jan 28, 2024
Merged

crypto_nodedev: improve reliability #5415

merged 1 commit into from
Jan 28, 2024

Conversation

smitterl
Copy link
Contributor

Waiting for udevadm settle doesn't seem to make sure Libvirt has the latest device information.

Instead add a sleep. If this doesn't fix the brittleness we might want to restart virtqemud.

@smitterl
crypto_nodedev: improve reliability
8d89d6b 
Waiting for udevadm settle doesn't seem to make sure
Libvirt has the latest device information.

Instead add a sleep. If this doesn't fix the brittleness
we might want to restart virtqemud.

Signed-off-by: Sebastian Mitterle <[email protected]>
@smitterl
Copy link
Contributor Author 

JOB ID     : 95e3faed53e0872d4ec1de0385ff13c5009e1836
JOB LOG    : /var/lib/avocado/job-results/job-2024-01-26T04.18-95e3fae/job.log
 (1/1) type_specific.io-github-autotest-libvirt.virsh.crypto_nodedev_create_destroy.positive: PASS (35.19 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/lib/avocado/job-results/job-2024-01-26T04.18-95e3fae/results.html
JOB TIME   : 35.57 s

dzhengfy
dzhengfy approved these changes Jan 28, 2024
View reviewed changes
Copy link
Contributor

@dzhengfy dzhengfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzhengfy dzhengfy merged commit 354fc05 into autotest:master Jan 28, 2024
5 checks passed
@smitterl smitterl deleted the improve_crypto_nodedev branch July 26, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzhengfy dzhengfy dzhengfy approved these changes

Assignees
No one assigned
Labels
minorfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smitterl @dzhengfy