add case for nvdimm turned to dram #6216
Conversation
xxxx-302271:Turned nvdimm to the regular DRAM Signed-off-by: nanli <[email protected]>
nanli1
force-pushed
the
add_case_for_nvdimm_tunred_to_dram
branch
from
206a320 to
2bc5c9c
Compare
|
@liang-cong-red-hat could you help review? |
|
LGTM.Acked-by: Zhenyu Zhang [email protected] |
| from provider.memory import memory_base | ||
|
|
||
|
|
||
| def execute_cmd_in_guest(test, session, cmd): |
There was a problem hiding this comment.
Is it simpler to reuse cmd_status_output() in avocado_vt/virttest/utils_misc.py ?
| @@ -270,3 +272,52 @@ def compare_values(test, expected, actual, check_item=''): | |||
| check_item, expected, actual)) | |||
| else: | |||
| test.log.debug("Check %s %s PASS", check_item, actual) | |||
|
|
|||
|
|
|||
| def check_boot_config(session, test): | |||
There was a problem hiding this comment.
Please help add a new paramater for check_list and move this function into avocado-vt/virttest/utils_libvirt/libvirt_bios.py
| test.fail('/boot/config content not correct: %s not exist' % item) | ||
|
|
||
|
|
||
| def check_used_memory_info(test, session=None): |
There was a problem hiding this comment.
The function name is inaccurate. Is it better if using get_memory_info_by_free_cmd() ?
Please move this function into avocado-vt/virttest/utils_libvirt/libvirt_memory.py
There was a problem hiding this comment.
And there is similar func here:avocado-vt/virttest/vt_utils/memory.py, you could use them directly if possible., like, get_used_mem, get_free_mem, etc.
There was a problem hiding this comment.
And there is similar func here:avocado-vt/virttest/vt_utils/memory.py, you could use them directly if possible., like, get_used_mem, get_free_mem, etc.
I did not see this vt_utils before. Yes, it seems better than libvirt_memory.py
| test.log.info("TEST_STEP5:Turned nvdimm to the regular DRAM, and hot-added memory matches the expectation") | ||
| if not utils_package.package_install('daxctl', session=session): | ||
| test.fail('Cannot install daxctl to vm') | ||
| if distro.detect().name == 'rhel' and int(distro.detect().version) == 9: |
There was a problem hiding this comment.
here better change to >=9
| test.fail('/boot/config content not correct: %s not exist' % item) | ||
|
|
||
|
|
||
| def check_used_memory_info(test, session=None): |
There was a problem hiding this comment.
And there is similar func here:avocado-vt/virttest/vt_utils/memory.py, you could use them directly if possible., like, get_used_mem, get_free_mem, etc.
Signed-off-by: nanli [email protected]