virtio_fs_localfs_migration: Migrate localfs with different cache modes #4184
Conversation
zhencliu
force-pushed
the
virtiofs_migration_localfs
branch
10 times, most recently
from
70593da to
7eb9f47
Compare
|
hi @hellohellenmao , would you please review this patch? I am not sure if this patch meet your expectation, I just follow Your palorion case's steps |
zhencliu
force-pushed
the
virtiofs_migration_localfs
branch
3 times, most recently
from
b8d9be4 to
54bce23
Compare
|
hi @hellohellenmao , would you please review it again? All test metrix was covered IMO, thanks. The following testing matrix is covered: Single node migration, with different localfs. |
|
Testing Win2022 and RHEL9.3 guest OS, all passed |
zhencliu
force-pushed
the
virtiofs_migration_localfs
branch
3 times, most recently
from
1662e04 to
2a44523
Compare
|
@xiagao Could you please help to take a review from windows perspective? |
Sure, will work on it after other tasks on hand. |
|
@fbq815 Could you please help to review here? Thanks. |
zhencliu
force-pushed
the
virtiofs_migration_localfs
branch
from
2a44523 to
44f08b6
Compare
zhencliu
force-pushed
the
virtiofs_migration_localfs
branch
from
44f08b6 to
550fa74
Compare
|
@zhencliu we use memory-backend-file on s390x when we use memory-backend with virtio-fs, please reference to the usage of avocado-framework/avocado-vt@85915c0 |
| 6. Run the virtiofsd daemon to share the directory in step5 | ||
| 7. Boot the target guest with the virtiofs device in step5 | ||
| 8. Do migration from the source guest to the target guest | ||
| 9. No error occurs, the virtiofs is mounted automatically and |
There was a problem hiding this comment.
@hellohellenmao Do we have steps to check if writing works on the virtiofs shared dir after migration?
There was a problem hiding this comment.
#4190 covered the writing scenario
There was a problem hiding this comment.
#4190 is based on NFS, @hellohellenmao what's your opinion? It's just a suggestion, I thought reading and writing are both important for virtiofs file system migration, they are the basic function.
There was a problem hiding this comment.
Hi @xiagao and @hellohellenmao , based on your inputs, I would like to echo something to the file after migration to test it's writable, thanks.
|
Test result on s390x: RHEL.10: @zhencliu the case LGTM and I'll ack once you update the note in the py file |
zhencliu
force-pushed
the
virtiofs_migration_localfs
branch
from
550fa74 to
526702b
Compare
zhencliu
force-pushed
the
virtiofs_migration_localfs
branch
2 times, most recently
from
1f99626 to
522f96a
Compare
Updated, note in cfg clarifies memory-backend-file can cause error while note in commit body shows the details |
|
Talked with @hellohellenmao , for the multifs scenario, we only cover cache mode auto. I have to sign the commit (Verified) later for something wrong happened to my account |
The following testing matrix is covered: cache mode: auto, never, always, metadata writeback: enabled and disabled allow-direct-io enabled and disabled count of fs: single fs and two fs Note we usually use memory-backend-file on s390x for the virtio-fs testing on RHEL, but for the live migration scenario, we have to use memory-backend-memfd due to RHEL-58831. Signed-off-by: Zhenchao Liu <[email protected]>
zhencliu
force-pushed
the
virtiofs_migration_localfs
branch
from
522f96a to
18bf913
Compare
|
Tested with rhel guest, all the cases passed. So the only comment from me for this patch is the same as Xiaoling mentioned that it's better to test the dir is writable after migration. |
ID: 2967