Virtiofs: Add test case support >=509 memslots #4204
Conversation
qcheng-redhat
changed the title
qcheng-redhat
changed the title
|
Hi @hellohellenmao, please help review this patch, when you have time. Thanks! |
|
@XueqiangWei @qcheng-redhat I've seens no s390x here, not sure if this needs my review |
| utils_disk.umount(fs_target, fs_dest, "virtiofs", session=session) | ||
| utils_misc.safe_rmdir(fs_dest, session=session) | ||
| if os_type == "windows": | ||
| virtio_fs_utils.delete_viofs_serivce(test, params, session) |
There was a problem hiding this comment.
Could you stop virtiofs service first and then delete it in case bringing the unexpected error?
And suggest to add win_driver_utils.memory_leak_check(vm, test, params) function in the end.
There was a problem hiding this comment.
Thanks for review. Updated.
| fs_driver_props = {"queue-size": 1024} | ||
| fs_source_type = mount | ||
| fs_source_dir = /var/tmp/virtio_fs_test | ||
| force_create_fs_source = no |
There was a problem hiding this comment.
All the fs paths are created by user, how about setting fs_source_user_config = yes, then it could save time in env_process.py
There was a problem hiding this comment.
A test file is created before test execution. So don't need create fs source again here.
Signed-off-by: qcheng-redhat <[email protected]>
qcheng-redhat
force-pushed
the
509-memslots
branch
from
2aae8df to
cb2cb19
Compare
@fbq815 Please refer to the polarion test case for more information about this patch. Thanks. |
| """ | ||
| 1) Boot a guest VM with virtio-fs device | ||
| 2) Check virtiofs basic functionality works | ||
| 3) Validate the virtio-mem device has the correct number of memslots |
There was a problem hiding this comment.
@hellohellenmao For the steps there is memslot check in polarion, I think it's better to have it here, what do you think ?
There was a problem hiding this comment.
Sorryt that I do not totally understand, from my understanding, it is checking the memslots here, what are the difference with yours?
There was a problem hiding this comment.
From my understanding, this case is adding virtio memory device to extend the memory, while virtiofs rely on the memory backend to work, so when the memory was plugged, I think it's necessary to checking the writing function.
| fs_driver_props = {"queue-size": 1024} | ||
| fs_source_type = mount | ||
| fs_source_dir = /var/tmp/virtio_fs_test | ||
| force_create_fs_source = no |
Add test case support >=509 memslots
ID: 3024